[Instrumentation.SqlClient] Adopt shared handle manager #2992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-hensley
had a problem deploying
to
external
GitHub Actions
Failure
github-actions
bot
added
comp:instrumentation.aspnet.telemetryhttpmodule
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
==========================================
- Coverage 66.12% 66.09% -0.03%
==========================================
Files 396 396
Lines 15815 15804 -11
==========================================
- Hits 10457 10446 -11
Misses 5358 5358
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@matt-hensley, blocking PR merged, could you please rebase/resolve conflicts? |
matt-hensley
force-pushed
the
sqlclient-handle-manager
branch
from
5fa9f38 to
42ed510
Compare
github-actions
bot
removed
the
comp:instrumentation.aspnet.telemetryhttpmodule
github-actions
bot
removed
the
comp:instrumentation.aspnet
martincostello
approved these changes
Aug 22, 2025
Kielek
approved these changes
Aug 26, 2025
Kielek
reviewed
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Modifies SqlClient instrumentation to use shared handle implementation setup in #2970
Leaving in draft until #2970 lands, will rebase afterwards
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes